apuc/guild
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor api/UserResponse

Browse Source
This commit is contained in:
iironside
2022-03-15 16:54:34 +03:00
parent 675d78b958
commit a5ef1d5008
5 changed files with 100 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
frontend/modules/api/controllers/UserQuestionnaireController.php
View File

@ -2,26 +2,14 @@
namespace frontend\modules\api\controllers;
use common\helpers\ScoreCalculatorHelper;
use common\services\ScoreCalculatorService;
use common\models\UserQuestionnaire;
use Yii;
use yii\filters\auth\HttpBearerAuth;
use yii\rest\Controller;
use yii\web\NotFoundHttpException;
class UserQuestionnaireController extends ApiController
{
public function behaviors()
{
$behaviors = parent::behaviors();
$behaviors['authenticator']['authMethods'] = [
HttpBearerAuth::className(),
];
return $behaviors;
}
public function verbs()
{
return [
@ -75,8 +63,8 @@ class UserQuestionnaireController extends ApiController
throw new NotFoundHttpException('Active questionnaire not found');
}
ScoreCalculatorHelper::rateResponses($userQuestionnaireModel);
ScoreCalculatorHelper::calculateScore($userQuestionnaireModel);
ScoreCalculatorService::rateResponses($userQuestionnaireModel);
ScoreCalculatorService::calculateScore($userQuestionnaireModel);
return $userQuestionnaireModel;
}

77
frontend/modules/api/controllers/UserResponseController.php
View File

@ -2,8 +2,8 @@
namespace frontend\modules\api\controllers;
use common\services\ScoreCalculatorService;
use common\models\UserResponse;
use common\services\UserResponseService;
use Yii;
use yii\base\InvalidConfigException;
use yii\web\BadRequestHttpException;
@ -11,8 +11,6 @@ use yii\web\ServerErrorHttpException;
class UserResponseController extends ApiController
{
public $modelClass = 'common\models\UserResponse';
public function verbs(): array
{
return [
@ -21,76 +19,31 @@ class UserResponseController extends ApiController
];
}
/**
* @throws InvalidConfigException
* @throws BadRequestHttpException
* @throws ServerErrorHttpException
* @throws ServerErrorHttpException|BadRequestHttpException
*/
public function actionSetResponse()
public function actionSetResponse(): UserResponse
{
$request = Yii::$app->getRequest()->getBodyParams();
$model = new UserResponse();
$model->load($request, '');
$this->validateResponseModel($model);
$this->saveModel($model);
return $model;
$userResponseModel = UserResponseService::createUserResponse(Yii::$app->getRequest()->getBodyParams());
if ($userResponseModel->errors) {
throw new ServerErrorHttpException(json_encode($userResponseModel->errors));
}
return $userResponseModel;
}
/**
* @throws InvalidConfigException
* @throws ServerErrorHttpException
* @throws BadRequestHttpException
* @throws ServerErrorHttpException|BadRequestHttpException
*/
public function actionSetResponses(): array
{
$requests = Yii::$app->getRequest()->getBodyParams();
$responseModels = array();
foreach ($requests['userResponses'] as $request) {
$model = new UserResponse();
$model->load($request, '');
$this->validateResponseModel($model);
array_push($responseModels, $model);
}
foreach ($responseModels as $responseModel) {
$this->saveModel($responseModel);
}
return $responseModels;
}
/**
* @throws BadRequestHttpException
*/
protected function validateResponseModel($model)
{
if(!$model->validate()) {
throw new BadRequestHttpException(json_encode($model->errors));
}
if (empty($model->user_id) or empty($model->question_id) or empty($model->user_questionnaire_uuid)) {
throw new BadRequestHttpException(json_encode($model->errors));
}
}
/**
* @throws ServerErrorHttpException
*/
protected function saveModel($model)
{
if ($model->save()) {
ScoreCalculatorService::rateOneResponse($model);
$response = Yii::$app->getResponse();
$response->setStatusCode(201);
} elseif (!$model->hasErrors()) {
throw new ServerErrorHttpException('Failed to create the object for unknown reason.');
$userResponseModels = UserResponseService::createUserResponses(Yii::$app->getRequest()->getBodyParams());
foreach ($userResponseModels as $model) {
if ($model->errors) {
throw new ServerErrorHttpException(json_encode($model->errors));
}
}
return $userResponseModels;
}
}